[SERVER-71485] Better naming for CanonicalQuery::isCount Created: 18/Nov/22  Updated: 29/Oct/23  Resolved: 12/Jan/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.3.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Alyssa Clark Assignee: Irina Yatsenko (Inactive)
Resolution: Fixed Votes: 0
Labels: neweng, quick-tech-debt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-79924 Use an accurate 'isCount' flag to enc... Closed
is related to SERVER-70617 Allow use of column indexes for count... Closed
Assigned Teams:
Query Execution
Backwards Compatibility: Fully Compatible
Participants:

 Description   

TheĀ CanonicalQuery::isCount flag is a somewhat inaccurate name, as it applies to a set of queries that is a superset of true count queries. We should consider naming it something more clear, e.g. needsSourceDocs (or the negated version to reduce code changes). Once we do this, terminology in comments and tests will need to be updated.



 Comments   
Comment by Githook User [ 12/Jan/23 ]

Author:

{'name': 'Irina Yatsenko', 'email': 'irina.yatsenko@mongodb.com', 'username': 'IrinaYatsenko'}

Message: SERVER-71485 Cleanup isCount on the canonical query
Branch: master
https://github.com/mongodb/mongo/commit/726e809bf3789c91c108b1db1e7edcc88a0f4c3e

Generated at Thu Feb 08 06:19:08 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.