[SERVER-71550] [CQF] Change Partial Schema Requirements map to vector Created: 22/Nov/22  Updated: 29/Oct/23  Resolved: 20/Jan/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.3.0-rc0

Type: Improvement Priority: Major - P3
Reporter: David Percy Assignee: David Percy
Resolution: Fixed Votes: 0
Labels: auto-reverted
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-70164 [CQF] Support Partial Schema Requirem... Closed
Problem/Incident
Backwards Compatibility: Fully Compatible
Sprint: QO 2022-12-12, QO 2022-12-26, QO 2023-01-09, QO 2023-01-23
Participants:
Linked BF Score: 43

 Description   

This is a prerequisite for SERVER-70164. Currently we have a map where each map-entry represents a predicate or projection, all connected by conjunction. We want to generalize this to support disjunction: BoolExpr<predicate or projection>.

So as a first step let's change the map to a vector. That way each predicate-or-projection will be represented as a single object, instead of being split into key/value.



 Comments   
Comment by Githook User [ 20/Jan/23 ]

Author:

{'name': 'David Percy', 'email': 'david.percy@mongodb.com', 'username': 'dpercy'}

Message: SERVER-71550 Change PartialSchemaRequirements map to vector
Branch: master
https://github.com/mongodb/mongo/commit/52832ac0d4440785350bfaab4ff0cbe8311875b7

Comment by Githook User [ 13/Jan/23 ]

Author:

{'name': 'David Percy', 'email': 'david.percy@mongodb.com', 'username': 'dpercy'}

Message: SERVER-71550 Simplify uses of PartialSchemaRequirements
Branch: master
https://github.com/mongodb/mongo/commit/7987f7ee0caa255732e3e3a88cb72e64d4e08a96

Comment by xgen-buildbaron-user [ 12/Jan/23 ]

Ticket re-opened due to revert. cqf_disabled_pipeline_opt began a consistent failure of jstests/cqf/elemmatch_bounds.js,jstests/cqf/analyze/ce_histogram.js,jstests/cqf/analyze/array_histogram.js,jstests/cqf/analyze/missing_histogram.js

Comment by Githook User [ 12/Jan/23 ]

Author:

{'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com'}

Message: Revert "SERVER-71550 Simplify uses of PartialSchemaRequirements"

This reverts commit b11ac4319479d03ee945a691b7ce679bccd75eda.
Branch: master
https://github.com/mongodb/mongo/commit/e2df7e4a84bf0bb443ece80026452383ca721c7e

Comment by Githook User [ 11/Jan/23 ]

Author:

{'name': 'David Percy', 'email': 'david.percy@mongodb.com', 'username': 'dpercy'}

Message: SERVER-71550 Simplify uses of PartialSchemaRequirements
Branch: master
https://github.com/mongodb/mongo/commit/b11ac4319479d03ee945a691b7ce679bccd75eda

Generated at Thu Feb 08 06:19:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.