[SERVER-71586] Remove usage of EExpression from EvalExpr Created: 23/Nov/22  Updated: 14/Mar/23

Status: Open
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Alberto Massari Assignee: Backlog - Query Execution
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-71585 Make SBE Stage Builder use ABT trees ... Closed
Assigned Teams:
Query Execution
Participants:

 Description   

... together with all the code using EvalExpr::EvalExpr(std::unique_ptr<EExpression*>), provided the same behavior is already present using the EvalExpr::EvalExpr(optimizer::ABT) variant



 Comments   
Comment by Ivan Fefer [ 24/Jan/23 ]

Removed EExpression from sbe_stage_builder_expression.cpp, complete remove from EvalExpr is possible only after we do the same for sbe_stage_builder_filter.cpp, which may or may not happen.

Comment by Githook User [ 24/Jan/23 ]

Author:

{'name': 'Ivan Fefer', 'email': 'ivan.fefer@mongodb.com', 'username': 'Fefer-Ivan'}

Message: SERVER-71586 Remove sbe::EExpression from sbe_stage_builder_expression.cpp
Branch: master
https://github.com/mongodb/mongo/commit/b79874da53786a13aa729627f300889fbb093c96

Comment by Ivan Fefer [ 24/Jan/23 ]

My PR only removes sbe::EExpression from sbe_stage_builder_expression and asserts that it is never used in this cpp files, but not generally in EvalExpr.

Comment by David Storch [ 30/Nov/22 ]

Got it, thanks.

Comment by Alberto Massari [ 30/Nov/22 ]

This is the final cleanup stage, after all the other tickets have added the generation of the ABT trees for each supported expression. I would wait for the other tasks to be done before pulling into a sprint

Comment by David Storch [ 30/Nov/22 ]

alberto.massari@mongodb.com should this be scheduled in a sprint?

Generated at Thu Feb 08 06:19:25 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.