[SERVER-71657] improve const-ness of OpObserver transaction-related events for TransactionOperations parameter Created: 28/Nov/22  Updated: 29/Oct/23  Resolved: 09/Dec/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.3.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-70899 move logOplogEntries() from OpObserve... Closed
is related to SERVER-71488 include multi-doc prepare info in Tra... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2022-12-12
Participants:

 Description   

The OpObserver interfaces currently accepts a pointer to the TransactionOperations container (see preTransactionPrepare, onTransactionPrepare, and onUnpreparedTransactionCommit) but none of the existing implementations need to modify the container's contents.

It would be clearer for the interface to accept a const ref to TransactionOperations.



 Comments   
Comment by Githook User [ 08/Dec/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-71657 OpObserver::onUnpreparedTransactionCommit() does not modify TransactionOperations
Branch: master
https://github.com/mongodb/mongo/commit/132abdec712421f4e700abd7ef2292d0bf20565f

Comment by Githook User [ 08/Dec/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-71657 OpObserver::onUnpreparedTransactionCommit() does not modify TransactionOperations

closes #777
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/3539cbbec61414f0c01301dcc54f725a2ea77582

Comment by Githook User [ 08/Dec/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-71657 OpObserver::preTransactionPrepare() does not modify TransactionOperations
Branch: master
https://github.com/mongodb/mongo/commit/f8554485c1b1121da12a29c627193aa340bf8245

Comment by Githook User [ 08/Dec/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-71657 OpObserver::preTransactionPrepare() does not modify TransactionOperations
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/8c9600ad7150feece811a1ed903d0909196ae853

Comment by Githook User [ 08/Dec/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-71657 OpObserver::onTransactionPrepare() accepts TransactionOperations
Branch: master
https://github.com/mongodb/mongo/commit/ba7582291759053f4a977ca4ddff411d78102dc2

Comment by Githook User [ 08/Dec/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-71657 OpObsever::onTransactionPrepare() accepts TransactionOperations
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/8830a88c4ed245b13e000bc25a34619cbc788e50

Comment by Githook User [ 08/Dec/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-71657 add TransactionOperations::getOperationsForOpObserver()

This replaces TransactionOperations::getMutableOperationsForOpObserver() now that we do not need
mutable access to the operations contained in TransactionOperations for writing applyOps entries.
Branch: master
https://github.com/mongodb/mongo/commit/b5e87afd73d9fd0e258262bb431c17bc1c9032e0

Generated at Thu Feb 08 06:19:38 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.