[SERVER-71657] improve const-ness of OpObserver transaction-related events for TransactionOperations parameter Created: 28/Nov/22 Updated: 29/Oct/23 Resolved: 09/Dec/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.3.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Benety Goh | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Execution Team 2022-12-12 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
The OpObserver interfaces currently accepts a pointer to the TransactionOperations container (see preTransactionPrepare, onTransactionPrepare, and onUnpreparedTransactionCommit) but none of the existing implementations need to modify the container's contents. It would be clearer for the interface to accept a const ref to TransactionOperations. |
| Comments |
| Comment by Githook User [ 08/Dec/22 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Githook User [ 08/Dec/22 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: closes #777 |
| Comment by Githook User [ 08/Dec/22 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Githook User [ 08/Dec/22 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Githook User [ 08/Dec/22 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Githook User [ 08/Dec/22 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Githook User [ 08/Dec/22 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: This replaces TransactionOperations::getMutableOperationsForOpObserver() now that we do not need |