[SERVER-71739] Move check newlines lint to clang-tidy Created: 01/Dec/22  Updated: 08/Feb/23  Resolved: 28/Jan/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Alex Neben Assignee: [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive)
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-55281 restore lint enforcement of newlines ... Closed
Assigned Teams:
Server Development Platform
Participants:

 Comments   
Comment by Billy Donahue [ 12/Jan/23 ]

I generally like moving our python/regex source checks into clang-tidy but I wouldn't do it for this check.

This check should run on all text files in the repo, including files that clang-tidy wouldn't be looking at.

It's not a check that needs clang's deep C++ knowledge to perform. it can be done with simple shell tooling as in the description of SERVER-55281. So I think we can leave clang-tidy out of this picture and maybe do something at the shell scripting level?

Generated at Thu Feb 08 06:19:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.