[SERVER-71743] Move polyfill lint to clang-tidy Created: 01/Dec/22 Updated: 29/Oct/23 Resolved: 21/Jun/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Alex Neben | Assignee: | Juan Gu |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Assigned Teams: |
Server Development Platform
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Comments |
| Comment by Githook User [ 21/Jun/23 ] |
|
Author: {'name': 'Juan Gu', 'email': 'juan.gu@mongodb.com', 'username': 'juangugit'}Message: |
| Comment by Githook User [ 13/Jun/23 ] |
|
Author: {'name': 'Juan Gu', 'email': 'juan.gu@mongodb.com', 'username': 'juangugit'}Message: Revert " This reverts commit 053876ef087379bbc88ed0e10f2b64215f6fb814. |
| Comment by Juan Gu [ 13/Jun/23 ] |
|
I will go ahead to revert it first to avoid more leaking. then we can try steve.gross@mongodb.com 's idea or other options. |
| Comment by Steve Gross [ 13/Jun/23 ] |
|
An option to consider: https://github.com/intel/hyperscan is an OSS library that provides a mechanism for high-performance regex execution (it compiles the regex so it runs "natively"). |
| Comment by Daniel Moody [ 13/Jun/23 ] |
|
The regex in the commit 053876ef087379bbc88ed0e10f2b64215f6fb814 is suspected of increasing the runtime of the checks significantly. We will need a revert because of this. |
| Comment by Githook User [ 13/Jun/23 ] |
|
Author: {'name': 'Juan Gu', 'email': 'juan.gu@mongodb.com', 'username': 'juangugit'}Message: |