[SERVER-71767] ClusterServerParameterRefresher deletes old parameters when not updated Created: 01/Dec/22  Updated: 29/Oct/23  Resolved: 23/Jan/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.3.0-rc0

Type: Bug Priority: Major - P3
Reporter: Gabriel Marks Assignee: Gabriel Marks
Resolution: Fixed Votes: 0
Labels: auto-reverted
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-72220 Separate validate from set for cluste... Closed
Problem/Incident
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Security 2022-12-12, Security 2022-12-26, Security 2023-01-09, Security 2023-01-23, Security 2023-02-06
Participants:
Linked BF Score: 135

 Description   

After changes made to accommodate having a minimum FCV for cluster parameters, ClusterServerParameterRefresher was erroneously changed such that if a parameter has not been updated since the last refresh, that parameter's value will be deleted locally on mongos, causing it to be set to default. This happened to only cause a bug in macOS, probably since all other variants were fast enough that the refresher never ran.



 Comments   
Comment by Githook User [ 23/Jan/23 ]

Author:

{'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}

Message: SERVER-71767 Pull all cluster parameters upon refresh
Branch: master
https://github.com/mongodb/mongo/commit/1cfa85beb181d84c524b95521abe6c5a14eda9de

Comment by xgen-buildbaron-user [ 15/Dec/22 ]

Ticket re-opened due to revert. serverless began a consistent failure of jstests/serverless/disabled_cluster_parameters_serverless.js

Comment by Githook User [ 15/Dec/22 ]

Author:

{'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com'}

Message: Revert "SERVER-71767 In ClusterServerParameterRefresher, don't delete non-updated parameters"

This reverts commit 49e41485fdd0501fe7f1ed642d12fd59d3f30b9e.
Branch: master
https://github.com/mongodb/mongo/commit/f12d0b467c8c995fdb9fd0e737809f99c99397f7

Comment by Githook User [ 14/Dec/22 ]

Author:

{'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}

Message: SERVER-71767 In ClusterServerParameterRefresher, don't delete non-updated parameters
Branch: master
https://github.com/mongodb/mongo/commit/49e41485fdd0501fe7f1ed642d12fd59d3f30b9e

Generated at Thu Feb 08 06:19:54 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.