[SERVER-71842] simplify logApplyOps (op_observer_impl.cpp) return type Created: 05/Dec/22  Updated: 29/Oct/23  Resolved: 05/Dec/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.3.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-34824 Make prepareTransaction command write... Closed
is related to SERVER-70899 move logOplogEntries() from OpObserve... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2022-12-12
Participants:

 Description   

The logApplyOps() function currently returns an OpTimeBundle, which is an internal type to op_observer_impl.cpp. The only caller of this function uses the `writeOpTime` and ignores the other fields. To simply the function signature and support integration with SERVER-70899, we could replace the return type with OpTime.



 Comments   
Comment by Githook User [ 05/Dec/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-71842 logApplyOps() does not need to return an OpTimeBundle
Branch: master
https://github.com/mongodb/mongo/commit/ebf36f0d163a7619740d6426a2f05881b6733900

Comment by Benety Goh [ 05/Dec/22 ]

This function was added in SERVER-34824. It appears the the two callers of the function in that commit (here and here) are only interested in the writeOpTime field.

Generated at Thu Feb 08 06:20:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.