[SERVER-7189] Apparent typo or cut-and-paste error in src/mongo/db/db.h Created: 27/Sep/12  Updated: 11/Jul/16  Resolved: 11/Mar/13

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: 2.2.0
Fix Version/s: 2.5.0

Type: Bug Priority: Minor - P4
Reporter: Tad Marshall Assignee: Tad Marshall
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:

 Description   

In src/mongo/db/db.h, line 39 in today's master branch seems misplaced:

            if( Lock::nested() ) {
                Lock::nested();
                massert(10298 , "can't temprelease nested lock", false);
            }

The second call to Lock::nested() doesn't do anything; it returns 'true' if the recursion count is greater than 1, but we already knew that from the line above and no one is looking at the result anyway.



 Comments   
Comment by auto [ 11/Mar/13 ]

Author:

{u'date': u'2013-01-15T21:41:32Z', u'name': u'Tad Marshall', u'email': u'tad@10gen.com'}

Message: SERVER-7189 Remove redundant call to Lock::nested()
Branch: master
https://github.com/mongodb/mongo/commit/3a2a35044db2205cf7f31ceb45436e2dab9f9a6e

Generated at Thu Feb 08 03:13:52 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.