[SERVER-71906] Fix naming of classes and files in the networking layer Created: 06/Dec/22  Updated: 29/Oct/23  Resolved: 25/Jan/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.3.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Matt Diener (Inactive) Assignee: Matt Diener (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Service Arch
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2022-12-26, Service Arch 2022-12-12, Service Arch 2023-01-09, Service Arch 2023-01-23, Service Arch 2023-02-06
Participants:

 Description   

Some guidelines:

  • Adjectives come before nouns in both file names and class names
  • When multiple adjectives are involved, use the following approach:
    • [Specific to implementation adj.][implementation][general adj.][noun]
    • E.g. BaseASIOSession, ASIONetworkInterface
  • Files will remain within the mongo/transport directory
  • Remove Session classes from parent classes to avoid applying the same adjective to a name 2 times, and to improve separation of responsibilities between classes in the networking layer.
    • E.g. TransportLayerASIO::ASIOSession -> BaseASIOSession


 Comments   
Comment by Githook User [ 24/Jan/23 ]

Author:

{'name': 'Matt Diener', 'email': 'matt.diener@mongodb.com', 'username': 'mattdiener'}

Message: SERVER-71906 move asio-related transport files to their own directory
Branch: master
https://github.com/mongodb/mongo/commit/b6152817bb33a1f128c54a8a95343dc8f57af64e

Comment by Githook User [ 18/Jan/23 ]

Author:

{'name': 'Matt Diener', 'email': 'matt.diener@mongodb.com', 'username': 'mattdiener'}

Message: SERVER-71906 Un-nest and fix cases of ASIO classes
Branch: master
https://github.com/mongodb/mongo/commit/c5d6033f73621d67bc4e24c4c32a1448a1f8b8f4

Comment by Githook User [ 09/Jan/23 ]

Author:

{'name': 'Matt Diener', 'email': 'matt.diener@mongodb.com', 'username': 'mattdiener'}

Message: SERVER-71906 rename BatonASIO to AsioNetworkingBaton
Branch: master
https://github.com/mongodb/mongo/commit/745ce7fed63de72f687f9faf057d90545b4e177d

Comment by Githook User [ 21/Dec/22 ]

Author:

{'name': 'Matt Diener', 'email': 'matt.diener@mongodb.com', 'username': 'mattdiener'}

Message: SERVER-71906 rename TransportLayerASIO to AsioTransportLayer
Branch: master
https://github.com/mongodb/mongo/commit/96eca5891fe7e7fa3cdc30950530249e2c109d31

Comment by Githook User [ 14/Dec/22 ]

Author:

{'name': 'Matt Diener', 'email': 'matt.diener@mongodb.com', 'username': 'mattdiener'}

Message: SERVER-71906 Fix cases on AsioSession
Branch: master
https://github.com/mongodb/mongo/commit/5e00c5519a9e89523305ce0f584d6a10cd665827

Comment by Githook User [ 08/Dec/22 ]

Author:

{'name': 'Matt Diener', 'email': 'matt.diener@mongodb.com', 'username': 'mattdiener'}

Message: SERVER-71906 rename session_asio to asio_session and autoformat
Branch: master
https://github.com/mongodb/mongo/commit/ef02f92d1e5627990be16f14a7cb6f30145ff7e1

Generated at Thu Feb 08 06:20:17 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.