[SERVER-71926] create linter rule for MONGO_LOGV2_DEFAULT_COMPONENT placement Created: 07/Dec/22  Updated: 08/Dec/22  Resolved: 08/Dec/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Benety Goh Assignee: Backlog - Service Architecture
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-71733 Add mongo-authored clang-tidy plugins... Closed
Related
is related to SERVER-66203 Sweep: move MONGO_LOGV2_DEFAULT_COMPO... Closed
is related to SERVER-71925 move MONGO_LOGV2_DEFAULT_COMPONENT be... Closed
Assigned Teams:
Service Arch
Participants:

 Description   

We did a sweep of our source files in SERVER-66203 to ensure that we define the log component below the header includes. It would be nice to look into enforcing this convention using a linter rule as part of the clang-tidy CI task or the cpplint tool.



 Comments   
Comment by Billy Donahue [ 07/Dec/22 ]

This is perhaps not a common enough regression to need a linter. The old convention of defining before including was unusual and shouldn't occur accidentally.

the regression that slipped back in feels like an isolated incident.

Generated at Thu Feb 08 06:20:20 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.