[SERVER-72079] Replace our resmoke custom scheduler with python scheduler Created: 13/Dec/22  Updated: 05/Feb/24

Status: Open
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Alex Neben Assignee: Mikhail Shchatko
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-79624 Upgrade windows python to 3.10 Closed
Related
is related to SERVER-42623 sched module in Python 3 causes close... Closed
Assigned Teams:
Correctness
Sprint: Build and Correctness OnDeck
Participants:
Story Points: 2

 Description   

The goal of the ticket is the following
1. Confirm the API changes causing the commented test in buildscripts/tests/resmokelib/utils/test_scheduler.py to fail is the "bug fix" that we needed.
2. If 1 is true then replace our uses of buildscripts/resmokelib/utils/scheduler.py with python's sched.
3. If one is false then fix and reenable the test.



 Comments   
Comment by Max Hirschhorn [ 10/Oct/23 ]

Does 3.9 not have the fix we need?

Correct, the changes from https://github.com/python/cpython/commit/5368c2b6e23660cbce7e38dc68f859c66ac349ee are only available starting in Python 3.10.

Comment by Mikhail Shchatko [ 10/Oct/23 ]

Opened draft PR: https://github.com/10gen/mongo/pull/16157

Comment by Mikhail Shchatko [ 10/Oct/23 ]

I guess no, it fails on Windows with its 3.9

Comment by Alex Neben [ 10/Oct/23 ]

If so then can you attach the PR to this ticket. Then I agree with you we should postpone the fix.

Comment by Alex Neben [ 10/Oct/23 ]

Does 3.9 not have the fix we need?

Comment by Mikhail Shchatko [ 10/Oct/23 ]

After enabling the test succeeds on Linux and fails on Windows: https://spruce.mongodb.com/version/652411ee850e619b11212a7f/tasks?page=0&sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC&taskName=buildscripts_test
This is because we use python 3.10 on Linux and using python 3.9 on Windows. From SERVER-79172 I see that we are not ready yet to bump python to 3.10 on Windows.
I think we should postpone and re-visit this ticket when we fully upgrade to python 3.10. alex.neben@mongodb.com does it sounds right to you?

Generated at Thu Feb 08 06:20:45 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.