[SERVER-72128] Make tenantId optional for TenantMigrationDonorDocument. Created: 14/Dec/22 Updated: 29/Oct/23 Resolved: 19/Sep/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.2.0-rc0, 7.1.0-rc3 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Didier Nadeau | Assignee: | Suganthi Mani |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | shard-merge-cleanup | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Assigned Teams: |
Serverless
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Backport Requested: |
v7.1
|
||||||||||||
| Sprint: | Server Serverless 2023-10-02 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
The tenantId field is not needed for Shard Merge. It will also not be needed by Sharding when it uses TMDS/TMRS. Therefore we should make the field optional as it's only needed for Tenant Migration. |
| Comments |
| Comment by Githook User [ 19/Sep/23 ] |
|
Author: {'name': 'Suganthi Mani', 'email': 'suganthi.mani@mongodb.com', 'username': 'smani87'}Message: (cherry picked from commit 988ca618ba7c702f680d27111858b85acf15183d) |
| Comment by Githook User [ 19/Sep/23 ] |
|
Author: {'name': 'Suganthi Mani', 'email': 'suganthi.mani@mongodb.com', 'username': 'smani87'}Message: |
| Comment by Suganthi Mani [ 19/Sep/23 ] |
|
I've reopened the issue because I believe that removing the tenantId field from the on-disk TenantMigrationDonorDocument could complicate things after deploying shard merge in production (where currently shard merge populating the tenantID field with an empty string), and has a potential risk of server crashes when POS attempts to rebuild the instance and failed to parse the state document (containing tenantId field) after binary upgrade. |