[SERVER-72164] Consider removing BatonHandle typedef Created: 15/Dec/22 Updated: 29/Oct/23 Resolved: 29/Jun/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | George Wangensteen | Assignee: | Jennifer Wang (Inactive) |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Service Arch
|
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Service Arch 2023-06-26, Service Arch 2023-07-10 |
| Participants: |
| Description |
|
Currently, the baton API defines a typedef of BatonHandle for std::shared_ptr<Baton>. It's come up serveral times that it's not obvious to readers from the name that BatonHandle provides the refcounting and other particular properties of shared_ptr that are often relied on when it is used. Since this "handle" doesn't provide any special properties and is just a typedef, it may be worth removing the typedef and just type std::shared_ptr<Baton> to remove this ambiguity. |