[SERVER-72181] [SBE] Investigate replacing usages of std::containers with absl::containers Created: 16/Dec/22  Updated: 24/Jan/23

Status: Backlog
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Kyle Suarez Assignee: Backlog - Query Execution
Resolution: Unresolved Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Query Execution
Participants:

 Description   

In SBE we seem to use std::hash_containers instead of the corresponding absl:: ones. This task is to investigate whether we can replace those usages, or to document why we need to keep them as-is.



 Comments   
Comment by Kyle Suarez [ 16/Dec/22 ]

Had a conversation with martin.neupauer@mongodb.com about this:

  • We think there are two usages, in hash lookup and hash join
  • Hash lookup can probably be replaced easily with Abseil
  • Hash join may actually depend on the fact that std:: container iterators have a stability guarantee, but we'd need to investigate further

Note that we also filed SERVER-72180 to see if it would be better to forgo either the std:: or absl:: containers with a custom-built one.

Generated at Thu Feb 08 06:21:03 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.