[SERVER-72238] Coverity analysis defect 134385: Redundant test Created: 19/Dec/22  Updated: 27/Oct/23  Resolved: 05/Jan/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Coverity Collector User Assignee: Ben Shteinfeld
Resolution: Gone away Votes: 0
Labels: coverity
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-71943 [CQF] Move ABT translation to the new... Closed
Operating System: ALL
Sprint: QO 2022-12-26, QO 2023-01-09
Participants:

 Description   

Redundant test

By the time the program execution reaches the test of this condition there is only one possible outcome for the test. The code at the destination of this branch is not dead, either because this condition is always true or because there is at least one other branch that reaches it. Test always evaluates the same
/src/mongo/db/pipeline/visitors/document_source_walker.cpp:98: DEADCODE 134385 At condition "this->visitHelper(ds)", the value of "this->visitHelper(ds)" must be equal to 0.
/src/mongo/db/pipeline/visitors/document_source_walker.cpp:97: DEADCODE 134385 The condition "this->visitHelper(ds)" cannot be true.



 Comments   
Comment by Ben Shteinfeld [ 05/Jan/23 ]

SERVER-71943 deletes the code which caused this issue.

Generated at Thu Feb 08 06:21:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.