[SERVER-7231] Replace log(int level) statements with LOG(int level) Created: 02/Oct/12 Updated: 11/Jul/16 Resolved: 24/Oct/12 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code, Logging |
| Affects Version/s: | 2.2.3 |
| Fix Version/s: | 2.2.4, 2.3.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Ben Becker | Assignee: | Shaun Verch |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Operating System: | ALL | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
The LOG() macro allows conditional logging without stream evaluation, while log() evaluates the stream regardless of the global log level. The task here is to remove all uses of log(int level) with a level >= 1, and replace them with LOG(). Note that log() messages are ok if they're information and not in a fast path (with some discretion). In the end, we should have the following log functions:
We will get rid of:
As this is a large change, we should focus on one component at a time and submit individual code reviews. A breakdown of the components for this task is forthcoming. |
| Comments |
| Comment by auto [ 06/Mar/13 ] |
|
Author: {u'date': u'2012-10-25T21:07:35Z', u'name': u'Shaun Verch', u'email': u'shaun.verch@10gen.com'}Message: Conflicts: |
| Comment by auto [ 06/Mar/13 ] |
|
Author: {u'date': u'2012-10-15T23:42:39Z', u'name': u'Shaun Verch', u'email': u'shaun.verch@10gen.com'}Message: |
| Comment by auto [ 06/Mar/13 ] |
|
Author: {u'date': u'2012-10-24T17:58:30Z', u'name': u'Shaun Verch', u'email': u'shaun.verch@10gen.com'}Message: |
| Comment by auto [ 06/Mar/13 ] |
|
Author: {u'date': u'2012-10-24T17:45:27Z', u'name': u'Shaun Verch', u'email': u'shaun.verch@10gen.com'}Message: Conflicts: |
| Comment by auto [ 06/Mar/13 ] |
|
Author: {u'date': u'2012-10-11T20:16:04Z', u'name': u'Shaun Verch', u'email': u'shaun.verch@10gen.com'}Message: |
| Comment by auto [ 25/Oct/12 ] |
|
Author: {u'date': u'2012-10-25T14:07:35-07:00', u'email': u'shaun.verch@10gen.com', u'name': u'Shaun Verch'}Message: |
| Comment by auto [ 24/Oct/12 ] |
|
Author: {u'date': u'2012-10-15T16:42:39-07:00', u'email': u'shaun.verch@10gen.com', u'name': u'Shaun Verch'}Message: |
| Comment by auto [ 24/Oct/12 ] |
|
Author: {u'date': u'2012-10-24T10:58:30-07:00', u'email': u'shaun.verch@10gen.com', u'name': u'Shaun Verch'}Message: |
| Comment by auto [ 24/Oct/12 ] |
|
Author: {u'date': u'2012-10-24T10:45:27-07:00', u'email': u'shaun.verch@10gen.com', u'name': u'Shaun Verch'}Message: |
| Comment by auto [ 24/Oct/12 ] |
|
Author: {u'date': u'2012-10-11T13:16:04-07:00', u'email': u'shaun.verch@10gen.com', u'name': u'Shaun Verch'}Message: |