[SERVER-72458] clarify or remove advanceNext return value Created: 02/Jan/23  Updated: 29/Oct/23  Resolved: 10/Feb/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.0.0-rc0

Type: Bug Priority: Major - P3
Reporter: Geert Bosch Assignee: Geert Bosch
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Storage Execution
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Execution Team 2023-02-20, Execution Team 2023-02-06
Participants:

 Description   

The WiredTigerIndexCursorBase::advanceNext method returns a boolean with an unclear and undocumented meaning. It appears to be return !_eof, but in actuality one code path ends up calling updatePosition(true) which may result in _eof being set, but a true value being returned.

It seems clear that some more documentation and testing is required at a minimum.



 Comments   
Comment by Githook User [ 08/Feb/23 ]

Author:

{'name': 'Geert Bosch', 'email': 'geert@mongodb.com', 'username': 'GeertBosch'}

Message: SERVER-72458 Clarify or remove advanceNext return value
Branch: master
https://github.com/mongodb/mongo/commit/a62982be1b4c13d4f4deada049ab0cd372aa22aa

Generated at Thu Feb 08 06:21:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.