[SERVER-72575] Remove kWantKey and kJustExistance RequestedInfo values Created: 05/Jan/23  Updated: 29/Oct/23  Resolved: 14/Jun/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Geert Bosch Assignee: Erin Liang
Resolution: Fixed Votes: 0
Labels: neweng, newgrad
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Storage Execution
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2023-06-12, Execution NAMR Team 2023-06-26
Participants:

 Description   

The kWantKey and kJustExistance options for SortedDataInterface::Cursor::RequestedInfo are not really used (the one use of kJustExistance is in code that shouldn't exist), and don't have any benefits today. Moreover they are not tested, and therefore likely to be buggy.

-------------------------------------------------------------------------------------------------
Benchmark                                       Time             CPU   Iterations UserCounters...
-------------------------------------------------------------------------------------------------
BM_Advance/AdvanceForwardWantKey         29782742 ns     29782523 ns           24 items_per_second=3.35767M/s
BM_Advance/AdvanceForwardWantLoc         18325059 ns     18324732 ns           38 items_per_second=5.45711M/s
BM_Advance/AdvanceForwardWantKeyAndLoc   29965805 ns     29964423 ns           23 items_per_second=3.33729M/s
BM_Advance/AdvanceForwardJustExistance   18430246 ns     18429362 ns           38 items_per_second=5.42612M/s



 Comments   
Comment by Githook User [ 14/Jun/23 ]

Author:

{'name': 'Erin Liang', 'email': 'erin.liang@mongodb.com', 'username': 'erl-ang'}

Message: SERVER-72575 Remove kWantKey and kJustExistance RequestedInfo Values
Branch: master
https://github.com/mongodb/mongo/commit/9d227452b5085b92651cc583d28d5ed5d734c4da

Generated at Thu Feb 08 06:22:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.