[SERVER-72614] Implement sampling for historgram computation Created: 08/Jan/23 Updated: 29/Oct/23 Resolved: 17/Jan/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.3.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Misha Tyulenev | Assignee: | Ben Shteinfeld |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | auto-reverted | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Sprint: | QO 2023-01-23 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Linked BF Score: | 49 | ||||||||||||||||
| Description |
|
Complete the POC from |
| Comments |
| Comment by Githook User [ 17/Jan/23 ] |
|
Author: {'name': 'Ben Shteinfeld', 'email': 'ben.shteinfeld@mongodb.com', 'username': 'bshteinfeld'}Message: |
| Comment by Ben Shteinfeld [ 17/Jan/23 ] |
|
Looks like this commit raced with https://github.com/10gen/mongo/commit/550e070c93e80bdb4f256dd634128ad919395eb0 which introduced the test which began failing. Running another evergreen patch to make sure the roll-forward is clean and then will submit. |
| Comment by Timour Katchaounov [ 17/Jan/23 ] |
|
ben.shteinfeld@mongodb.com the change is load_data.js is correct - you just need to update the expected golden test file. Your change is just adding one extra histogram field - sampleRate, and this is fine. Could you commit this change today, and close this task? |
| Comment by xgen-buildbaron-user [ 14/Jan/23 ] |
|
Ticket re-opened due to revert. query_golden_cqf began a consistent failure of jstests\query_golden\load_data.js |
| Comment by Githook User [ 14/Jan/23 ] |
|
Author: {'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com'}Message: Revert " This reverts commit 01e8c11aa89f83f196029f56205be1614094e15a. |
| Comment by Githook User [ 13/Jan/23 ] |
|
Author: {'name': 'Ben Shteinfeld', 'email': 'ben.shteinfeld@mongodb.com', 'username': 'bshteinfeld'}Message: |