[SERVER-72676] Remove redudant constraint check for journalCommitInterval Created: 10/Jan/23  Updated: 13/Feb/23

Status: Backlog
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Yujin Kang Park Assignee: Backlog - Storage Execution Team
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-72675 Values passed by --setParameter not a... Closed
Assigned Teams:
Storage Execution
Participants:

 Description   

journalCommitInterval and storage.journal.commitIntervalMs both add constraints on the parameter in:

https://github.com/10gen/mongo/blob/1eb33d31a32bb7d1a1a18e07c78239b90a9dd5d3/src/mongo/db/mongod_options_storage.idl#L102

https://github.com/10gen/mongo/blob/1eb33d31a32bb7d1a1a18e07c78239b90a9dd5d3/src/mongo/db/storage/storage_parameters.idl#L58

Additionally, there's validation in

https://github.com/10gen/mongo/blob/1eb33d31a32bb7d1a1a18e07c78239b90a9dd5d3/src/mongo/db/mongod_options.cpp#L436

I believe at least the check in mongod_options.cpp is redundant. Not sure about the relationship between mongod_options_storage.idl and storage_parameters.idl, but it also looks redundant.


Generated at Thu Feb 08 06:22:29 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.