[SERVER-72878] Windows compilation fails with cl Version 19.34.31937 for x64 Created: 16/Jan/23 Updated: 02/Feb/24 |
|
| Status: | In Code Review |
| Project: | Core Server |
| Component/s: | Query Execution |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Marcos José Grillo Ramirez | Assignee: | Justin Seyster |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Assigned Teams: |
Query Execution
|
||||||||||||
| Sprint: | QE 2023-05-15, QE 2023-05-29, QE 2023-06-12, QE 2023-06-26, QE 2023-07-10, QE 2023-07-24, QE 2023-08-07, QE 2023-08-21, QE 2023-09-04, QE 2023-09-18, QE 2023-10-02, QE 2023-10-16, QE 2023-10-30, QE 2023-11-13, QE 2023-11-27, QE 2023-12-11, QE 2023-12-25, QE 2024-01-08, QE 2024-01-22, QE 2024-02-05, QE 2024-02-19 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
After updating to Visual Studio ver. 17.4.3 there are some compilation errors that seem related to SERVER-65148, the error shown when trying to build is the following:
The following diff solves the issue:
Basically moving the ifdef's before the switch. |
| Comments |
| Comment by Githook User [ 22/Dec/23 ] | ||
|
Author: {'name': 'Justin Seyster', 'email': 'justin.seyster@mongodb.com', 'username': 'jseyster'}Message: SERVER-72878 Work around MSVC internal compiler error in MozJS GitOrigin-RevId: a40486e2c81a29fd91e685c1185c030d5c566116 | ||
| Comment by Andrew Morton [ 04/Oct/23 ] | ||
|
Yep, I've managed to hit the same
error on 3 consecutive patch executions. We're using hosts with a newer Windows SDK which is likely the reason it repros reliably now. | ||
| Comment by Justin Seyster [ 03/Oct/23 ] | ||
|
andrew.morton@mongodb.com Thanks for following up. Is the failure in BUILD-17821 something that reproduces consistently? This ICE has popped up a few times, but never reliably. I'm going to be making some mozjs changes when my current project wraps up, so that would be a good time for me to revisit this and test out possible workarounds. If we have a reliable repro, I may also be able to file an actionable bug report with the MSVC team. | ||
| Comment by Luke Pearson [ 17/Sep/23 ] | ||
|
Bumping this ticket, we encountered this when trying to upgrade to a newer Visual studio version in BUILD-17821. It seems like it hasn't gone away at least for visual studio version vs_Professional_17.7.1.exe. Is there a path forward here? | ||
| Comment by Marcos José Grillo Ramirez [ 18/May/23 ] | ||
|
kyle.suarez@mongodb.com justin.seyster@mongodb.com I've checked and it went away, I'm not sure when. | ||
| Comment by Kyle Suarez [ 18/May/23 ] | ||
|
justin.seyster@mongodb.com, is this an actual active issue? Or did the compile break go away between Feb and now? CC amr.elhelw@mongodb.com |