[SERVER-73026] LogCaptureSink: ensure no incoming traffic after stop is requested Created: 19/Jan/23 Updated: 29/Oct/23 Resolved: 20/Jan/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.3.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Billy Donahue | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Operating System: | ALL | ||||
| Sprint: | Service Arch 2023-01-23 | ||||
| Participants: | |||||
| Linked BF Score: | 0 | ||||
| Description |
|
[Fix BF-26347] The boost::log API uses shared_ptr extensively. The call to stopCapturingLogMessages doesn't kill the sink, but it does remove it from the core, so it shouldn't be receiving new messages. But it will survive and continue delivering any log messages that it had already received but not yet delivered at the time it was detached, which is IIUC what's going on here. A couple of things that might work?
Draft fix: https://github.com/10gen/mongo/pull/9869 Confirmation of this behavior from Andrey Semashev, boost::log's maintainer. |
| Comments |
| Comment by Githook User [ 20/Jan/23 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |