[SERVER-73060] Remove lock upgrade tests in LockManagerTest Created: 19/Jan/23  Updated: 10/Jan/24  Resolved: 09/Jan/24

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Fausto Leyva (Inactive) Assignee: Gregory Noma
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates SERVER-73040 Ban all lock upgrades Closed
Assigned Teams:
Storage Execution NAMER
Sprint: Execution Team 2023-03-20, Execution Team 2023-05-01, Execution Team 2023-05-29, Execution Team 2023-06-12, Execution Team 2024-01-22
Participants:

 Description   

There are a few tests in lock_manager_test.cpp which exercise lock upgrades, for example: https://github.com/10gen/mongo/blob/c8f6bd7b917856060fdfb2d78dab17b734fc4848/src/mongo/db/concurrency/lock_manager_test.cpp#L207

We should remove these tests as they will be obsolete when we ban lock upgrades.



 Comments   
Comment by Gregory Noma [ 25/Aug/23 ]

Since these are the unit tests for lock upgrading itself, I think we should close this as a duplicate of SERVER-73040 and remove the unit tests as a part of that ticket. The tests include:

  • GrantRecursiveCompatibleConvertUp
  • GrantRecursiveNonCompatibleConvertUp
  • GrantRecursiveNonCompatibleConvertDown
  • CancelWaitingConversionWeakModes
  • CancelWaitingConversionStrongModes
  • ConflictingConversion
  • ConflictingConversionInTheMiddle
  • ConvertUpgrade
  • ConflictUpgradeWithTimeout
  • ConvertLockPendingUnlock
  • ConvertLockPendingUnlockAndUnlock
Generated at Thu Feb 08 06:23:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.