[SERVER-73394] Remove misleading operationsBlockedByRefresh metrics Created: 27/Jan/23  Updated: 29/Oct/23  Resolved: 07/Mar/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.0.0-rc0, 6.0.10, 5.0.21, 4.4.25

Type: Bug Priority: Major - P3
Reporter: Tommaso Tocci Assignee: Pol Pinol
Resolution: Fixed Votes: 0
Labels: sharding-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
is depended on by COMPASS-6589 Investigate changes in SERVER-73394: ... Closed
Documented
is documented by DOCS-15949 Investigate changes in SERVER-73394: ... Closed
Problem/Incident
is caused by SERVER-46396 Add metrics to track number of operat... Closed
Related
Assigned Teams:
Sharding EMEA
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v6.0, v5.0, v4.4
Sprint: Sharding EMEA 2023-02-20, Sharding EMEA 2023-03-06
Participants:

 Description   

The operationsBlockedByRefresh counters are increased on mongos for every operation that use collection routing information even if the operation haven't been blocked by a catalog refresh.

In fact all operations that requires collection routing information end up calling  CatalogCache::_getCollectionPlacementInfoAt . In this function we unconditionally set the operationBlockedBheindCatalogCacheRefres boolean to true and when the operation completes we execute CatalogCache::checkAndRecordOperationBlockedByRefresh that increase the metric counters.

This metric has been introduced by SERVER-46396 as part of PM-1633. The future flag for this project have been disabled because we discovered was causing performance regression.
This goal of this ticket is to remove this wrong and misleading metric to avoid confusion.



 Comments   
Comment by Githook User [ 24/Aug/23 ]

Author:

{'name': 'Pol Pinol Castuera', 'email': 'pol.pinol@mongodb.com', 'username': 'PolPinol'}

Message: SERVER-73394 Remove operationsBlockedByRefresh metrics

(cherry picked from commit a1828809c81e1e96e51784095bfc9055a4e2b4d6)
Branch: v4.4
https://github.com/mongodb/mongo/commit/f5a1806fc8e3a73018d45529295ecda766cb586e

Comment by Githook User [ 24/Aug/23 ]

Author:

{'name': 'Pol Pinol Castuera', 'email': 'pol.pinol@mongodb.com', 'username': 'PolPinol'}

Message: SERVER-73394 Remove operationsBlockedByRefresh metrics

(cherry picked from commit a1828809c81e1e96e51784095bfc9055a4e2b4d6)
Branch: v5.0
https://github.com/mongodb/mongo/commit/94ea7e5c8edf49fb3253daa1a301031fb899e005

Comment by Githook User [ 17/Aug/23 ]

Author:

{'name': 'Pol Pinol Castuera', 'email': 'pol.pinol@mongodb.com', 'username': 'PolPinol'}

Message: SERVER-73394 Remove operationsBlockedByRefresh metrics

(cherry picked from commit a1828809c81e1e96e51784095bfc9055a4e2b4d6)
Branch: v6.0
https://github.com/mongodb/mongo/commit/36d5f9aa003438479ea85c73c6c084041aab9588

Comment by Githook User [ 07/Mar/23 ]

Author:

{'name': 'Pol Pinol Castuera', 'email': 'pol.pinol@mongodb.com', 'username': 'PolPinol'}

Message: SERVER-73394 Remove operationsBlockedByRefresh metrics
Branch: master
https://github.com/mongodb/mongo/commit/a1828809c81e1e96e51784095bfc9055a4e2b4d6

Generated at Thu Feb 08 06:24:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.