[SERVER-73530] TransactionClient API to use DatabaseName objects rather than strings Created: 01/Feb/23 Updated: 29/Oct/23 Resolved: 16/Feb/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.0.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Mathis Bessa | Assignee: | Mathis Bessa |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Serverless
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Server Serverless 2023-02-20 | ||||||||
| Participants: | |||||||||
| Description |
|
We can use OpMsgRequestBuilder::create() rather than OpMsgRequest::fromDBAndBody when creating the opMsg request in SEPTransactionClient::runCommand - otherwise we may include the wrong serialized version of database name in the op msg request (we may include a prefix even when we're setting $tenant here). It works now because we always pass the non-prefixed db name to SEPTransactionClient::runCommand in this file by calling .db() on the DatabaseName. Change SEPTransactionClient::runCommand to use a DatabaseName instead of a StringData and internally call OpMsgRequestBuilder::create instead of OpMsgRequest::fromDBAndBody. |
| Comments |
| Comment by Githook User [ 16/Feb/23 ] |
|
Author: {'name': 'mathisbessamdb', 'email': 'mathis.bessa@mongodb.com', 'username': 'mathisbessamdb'}Message: |