[SERVER-73540] Get rid of balancer policy abstract classes Created: 02/Feb/23  Updated: 29/Oct/23  Resolved: 01/Jun/23

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Silvia Surroca Assignee: Antonio Fuschetto
Resolution: Fixed Votes: 0
Labels: sharding-wfbf-day
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Sharding EMEA
Backwards Compatibility: Fully Compatible
Sprint: Sharding EMEA 2023-06-12
Participants:

 Description   

The BalancerDefragmentationPolicy and the BalancerChunkSelectionPolicy have both an abstract class and a single implementation of it.

Abstract classes are on balancer_defragmentation_policy.h and balancer_chunk_selection_policy.h
Implementations are on balancer_defragmentation_policy_impl.h and balancer_chunk_selection_policy_impl.h

We consider that there is no need to have an abstract class since there is only a single implementation and there is no plan to create any testing mock of them.

The aim of this ticket is to get rid of the abstract class files, remove the *impl.h suffix from the balancer_*_impl.h files and remove also the *Impl suffix of the BalancerDefragmentationPolicyImpl and BalancerChunkSelectionPolicyImpl classes.

 

Note: There is no need to do the same with `ClusterChunksResizePolicy` since it will go away on SERVER-66652



 Comments   
Comment by Githook User [ 01/Jun/23 ]

Author:

{'name': 'Antonio Fuschetto', 'email': 'antonio.fuschetto@mongodb.com', 'username': 'afuschetto'}

Message: SERVER-73540 Get rid of balancer policy abstract classes
Branch: master
https://github.com/mongodb/mongo/commit/a1775cfb8d7f1a4343b2b0138d4b45635d34db1e

Generated at Thu Feb 08 06:24:57 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.