[SERVER-73659] Account for size of KVMap in LRUKeyValue cache memory budget tracking Created: 06/Feb/23 Updated: 24/May/23 Resolved: 27/Apr/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Maddie Zechar | Assignee: | Backlog - Query Optimization |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Assigned Teams: |
Query Optimization
|
||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Description |
|
With changes from
LRUKeyValue should maintain its own budge tracker for this overhead cost. It might make sense to replace the estimator from LRUBudgetTracker with a lambda:
This would call the estimator defined in LRUKeyValue which would have a flag for including overhead size or not in total size. In case of classic plan cache, we only want to know number of entries. We do not care about the size of the keys, size of the plans, or size of overhead. However, we do care about size of overhead for SBE plan cache and telemetry. |
| Comments |
| Comment by Githook User [ 24/May/23 ] |
|
Author: {'name': 'Anton Korshunov', 'email': 'anton.korshunov@mongodb.com', 'username': 'antkorsh'}Message: |
| Comment by David Storch [ 26/Apr/23 ] |
|
Marking this for re-triage. I filed I believe that we can close this ticket as "Won't Fix". While we could account for the overhead of LRUKeyValue::_kvMap, I'm not sure that we really need to do so. It seems sufficient if the sum of the size estimates of the (key, value) pairs stored within the data structure fit within the budget. If we do decide not to do this ticket, note that there is a "TODO" comment in the code base that needs to be cleaned up before this ticket is resolved. |
| Comment by Anton Korshunov [ 15/Feb/23 ] |
|
See this comment. |