[SERVER-73689] Fix shard key update check in update_stage.cpp to exclude _id queries Created: 06/Feb/23  Updated: 29/Oct/23  Resolved: 28/Feb/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.0.0-rc0

Type: Task Priority: Major - P3
Reporter: Jason Zhang Assignee: Jason Zhang
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-74354 Update and delete size estimation log... Closed
Backwards Compatibility: Fully Compatible
Sprint: Sharding NYC 2023-02-20, Sharding NYC 2023-03-06
Participants:
Linked BF Score: 160

 Description   

Documented here: https://github.com/10gen/mongo/pull/10271#discussion_r1097928283

Replacement updates currently have logic that use the replacement doc for targeting, which would result in _id query replacement updates containing a valid shard version, bypassing the feature guard in update_stage.cpp



 Comments   
Comment by Githook User [ 28/Feb/23 ]

Author:

{'name': 'Jason Zhang', 'email': 'jason.zhang@mongodb.com', 'username': 'jz1242'}

Message: SERVER-73689 Fix shard key update check in update_stage.cpp to exclude _id queries
Branch: master
https://github.com/mongodb/mongo/commit/951a2ddf46b4835dff8f407b12f8011a4071c62c

Comment by Githook User [ 27/Feb/23 ]

Author:

{'name': 'Uladzimir Makouski', 'email': 'uladzimir.makouski@mongodb.com', 'username': 'umakouski'}

Message: Revert "SERVER-73689 Fix shard key update check in update_stage.cpp to exclude _id queries"

This reverts commit 30d0c50b89881e6970627093bdae476a2fcc338e.
Branch: master
https://github.com/mongodb/mongo/commit/ec56432e853388525db01a50b43b0488c07c680d

Comment by Githook User [ 23/Feb/23 ]

Author:

{'name': 'Jason Zhang', 'email': 'jason.zhang@mongodb.com', 'username': 'jz1242'}

Message: SERVER-73689 Fix shard key update check in update_stage.cpp to exclude _id queries
Branch: master
https://github.com/mongodb/mongo/commit/30d0c50b89881e6970627093bdae476a2fcc338e

Generated at Thu Feb 08 06:25:21 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.