[SERVER-73699] SessionWorkflow improvements Created: 07/Feb/23  Updated: 29/Oct/23  Resolved: 08/Feb/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.0.0-rc0, 6.3.0-rc1

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Problem/Incident
Related
is related to SERVER-73623 SessionWorkflow: yield before _receiv... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v6.3
Sprint: Service Arch 2023-02-20
Participants:
Linked BF Score: 120

 Description   

While searching for the cause of performance issue BF-27452, we discovered a few things that were not the cause, but were still worthy of improvement.

Redundant yield. The fix SERVER-73623 added a yield before _receiveRequest, but did not remove the yield after sendResponse. Testing shows that we don't need the yield after sendResponse anymore.

Unnecessary binding of Frame to a shared_ptr, copied into lambdas. This could be a data member of SessionWorkflow.



 Comments   
Comment by Githook User [ 15/Feb/23 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-73699 SessionWorkflow: remove redundant yield and Frame shared_ptrs

(cherry picked from commit 294d9e038f972e4ee6c4c1d155df20f59e725932)
Branch: v6.3
https://github.com/mongodb/mongo/commit/5a8a7076ad21c779a2f127df6276cabd5083ea8d

Comment by Githook User [ 08/Feb/23 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-73699 SessionWorkflow: remove redundant yield and Frame shared_ptrs
Branch: master
https://github.com/mongodb/mongo/commit/294d9e038f972e4ee6c4c1d155df20f59e725932

Generated at Thu Feb 08 06:25:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.