[SERVER-73763] Resharding does not extend zone ranges for config.tag docs, leading to config server primary fassert loop from duplicate key error Created: 08/Feb/23  Updated: 20/Nov/23  Resolved: 01/May/23

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: 5.0.0, 6.0.0, 6.3.0-rc0
Fix Version/s: 7.1.0-rc0, 7.0.5, 6.0.13, 5.0.24

Type: Bug Priority: Major - P3
Reporter: Kshitij Gupta Assignee: Nandini Bhartiya
Resolution: Fixed Votes: 0
Labels: sharding-nyc-subteam1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
related to SERVER-73848 Hashed shard keys with zones can caus... Closed
is related to SERVER-53432 Ensure that comparing resharding requ... Closed
is related to SERVER-58433 ReshardingCoordinatorService Transact... Closed
Assigned Teams:
Sharding NYC
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v7.0, v6.3, v6.0, v5.0
Sprint: Sharding NYC 2023-04-03, Sharding NYC 2023-04-17, Sharding NYC 2023-05-01, Sharding NYC 2023-05-15
Participants:
Story Points: 3

 Description   

Resharding will add documents to config.tags collection with the new temporary resharding namespace. But these docs, don't extend the zone range to encompass the entire sharding key pattern. The tag documents to be uploaded to config.tags are built here:

https://github.com/mongodb/mongo/blob/f2a95d46b1d5ba667048a937fd73de43c391f569/src/mongo/db/s/resharding/resharding_util.cpp#L226

This function should be doing something similar to the resharding split policy (taking in the new resharding key and calling extend range on it) like this:

https://github.com/mongodb/mongo/blob/f2a95d46b1d5ba667048a937fd73de43c391f569/src/mongo/db/s/config/initial_split_policy.cpp#L696



 Comments   
Comment by Abdul Qadeer [ 14/Nov/23 ]

Doesn't look like it. It showed 5.0.23 as the latest unreleased version so I picked that. Will check if there will be an rc1, if not then I will update the fix version.

Edit: There is no 5.0.23-rc1. I have removed the 5.0.23 version for now as 5.0.24 doesn't exist yet. Will revisit again.

Comment by Garaudy Etienne [ 14/Nov/23 ]

abdul.qadeer@mongodb.com did this actually make 5.0.23 considering rc0 was cut yesterday?

Comment by Githook User [ 14/Nov/23 ]

Author:

{'name': 'Abdul Qadeer', 'email': 'abdul.qadeer@mongodb.com', 'username': 'zorro786'}

Message: SERVER-73763: Ensure zones are extended for config.tags docs

(cherry picked with changes from commit 8b334a85333aaeedb8b71f9b4916a9d6f2d222d6)
Branch: v6.0
https://github.com/mongodb/mongo/commit/a5ca4e5ccfcb794a533aa3d414c50207d8d26132

Comment by Githook User [ 14/Nov/23 ]

Author:

{'name': 'Abdul Qadeer', 'email': 'abdul.qadeer@mongodb.com', 'username': 'zorro786'}

Message: SERVER-73763: Ensure zones are extended for config.tags docs

(cherry picked from commit 5fe753ccbf09562b4eda82292668f0801883294f)
Branch: v5.0
https://github.com/mongodb/mongo/commit/961e54e1ce186f3abf6b27525b199ac2bebb4ba0

Comment by Githook User [ 14/Nov/23 ]

Author:

{'name': 'nandinibhartiyaMDB', 'email': 'nandini.bhartiya@mongodb.com', 'username': 'nandinibhartiyaMDB'}

Message: SERVER-73763: Ensure zones are extended for config.tags docs

(cherry picked from commit 8b334a85333aaeedb8b71f9b4916a9d6f2d222d6)
Branch: v7.0
https://github.com/mongodb/mongo/commit/328c07eeac67500d8570ea8e0493f3d3502b44a9

Comment by Githook User [ 18/Apr/23 ]

Author:

{'name': 'nandinibhartiyaMDB', 'email': 'nandini.bhartiya@mongodb.com', 'username': 'nandinibhartiyaMDB'}

Message: SERVER-73763: Ensure zones are extended for config.tags docs
Branch: master
https://github.com/mongodb/mongo/commit/8b334a85333aaeedb8b71f9b4916a9d6f2d222d6

Generated at Thu Feb 08 06:25:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.