[SERVER-73863] Test that configuring telemetry cache size to 0 will clear the cache Created: 09/Feb/23  Updated: 29/Oct/23  Resolved: 17/Mar/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.0.0-rc0

Type: Task Priority: Major - P3
Reporter: Charlie Swanson Assignee: Maddie Zechar
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Query Optimization
Backwards Compatibility: Fully Compatible
Sprint: QO 2023-03-20
Participants:

 Description   

This seems like a somewhat common scenario where an administrator would want to clear the cache out if the process is running low on memory or if they decide that telemetry cannot be recorded. Let's just make sure nothing crashes and that we do indeed clear out the cache.



 Comments   
Comment by Githook User [ 16/Mar/23 ]

Author:

{'name': 'Maddie Zechar', 'email': 'mez2113@columbia.edu', 'username': ''}

Message: SERVER-73863 allow cluster admin to reset telemetry store to 0 bytes
Branch: master
https://github.com/mongodb/mongo/commit/6874e02c337a73f20ebb883c0a8e98d491768c89

Comment by Maddie Zechar [ 07/Mar/23 ]

Oh gosh, butterfingers. Here is the raw link https://github.com/10gen/mongo/blob/dd2220a2224fd855743af88060b0a94e65a378cd/src/mongo/db/query/util/memory_util.cpp#L96-L98

 

and ok, sounds good

Comment by Charlie Swanson [ 07/Mar/23 ]

Oh no! The link to the uassert is just linking me back to this ticket (wrong copy/paste?), but yeah I think setting to minimum size would be fine. Or perhaps making it a nullable pointer to the telemetry store - something to effectively clear it.

Comment by Maddie Zechar [ 06/Mar/23 ]

I think the use case described in the ticket makes a lot of sense. However, this setting the cache size to 0 trips this uassert  

 

Perhaps when a user tries to set the cache to 0, we could clear the cache and set it to the minimum required size?

Generated at Thu Feb 08 06:25:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.