Investigate apparent regression in classic engine IDHACK (SERVER-68110)

[SERVER-73909] only call serializeDollarDbInOpDescription() in multi-tenant mode Created: 10/Feb/23  Updated: 29/Oct/23  Resolved: 24/Feb/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.0.0-rc0

Type: Sub-task Priority: Major - P3
Reporter: Colin Stolley Assignee: Colin Stolley
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: QE 2023-05-15
Participants:

 Description   

serializeDollarDbInOpDescription() is a fairly expensive call as it calls BSONObj::AddField() which makes an entirely new copy of the object. This is done on every query so it's a hot path.

We can skip it if we're not in multi-tenant mode, which is an easy check.



 Comments   
Comment by Githook User [ 22/Feb/23 ]

Author:

{'name': 'Colin Stolley', 'email': 'colin.stolley@mongodb.com', 'username': 'ccstolley'}

Message: SERVER-73909: Avoid call to serializeDollarDbInOpDescription()
Branch: master
https://github.com/mongodb/mongo/commit/24f148eec2575aff086f596075441cbfde79b9bc

Generated at Thu Feb 08 06:25:58 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.