[SERVER-74047] Refactor SerializationOptions by removing MatchExpression-specific fields Created: 15/Feb/23  Updated: 29/Oct/23  Resolved: 07/Oct/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.2.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Charlie Swanson Assignee: Reilly McBride
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-73709 Query shape (literal redaction) for $... Closed
is depended on by SERVER-85065 Tracking: M3 Tech Debt Tickets Closed
Issue split
split to SERVER-81902 Change name of SerializationOptions Closed
split to SERVER-81906 Refactor SerializationOptions by remo... Closed
Assigned Teams:
Query Integration
Backwards Compatibility: Fully Compatible
Participants:

 Description   

It currently contains a bool includePath which is only relevant for MatchExpressions

The proposed idea is to split that out so we would have MatchExpression::serialize(bool includePath, SerializationOptions = {})

 

 



 Comments   
Comment by Githook User [ 06/Oct/23 ]

Author:

{'name': 'Reilly McBride', 'email': 'reilly.mcbride@mongodb.com', 'username': ''}

Message: SERVER-74047 getting rid of includePath as a SerializationOptions field and instead adding it as an arg to MatchExpression serialization functions
Branch: master
https://github.com/mongodb/mongo/commit/d57bfc4ae8763c947faaff22dd7468a2038e9b78

Comment by Charlie Swanson [ 03/Apr/23 ]

I'm adding the back to the epic for consideration. I think this is indeed an optional refactor, but I would advocate to spend the time on it while we're here and paying attention. It will make the code much more self-documenting and modularized, which will aid many future readers.

Generated at Thu Feb 08 06:26:21 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.