[SERVER-74047] Refactor SerializationOptions by removing MatchExpression-specific fields Created: 15/Feb/23 Updated: 29/Oct/23 Resolved: 07/Oct/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.2.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Charlie Swanson | Assignee: | Reilly McBride |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Assigned Teams: |
Query Integration
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Description |
|
It currently contains a bool includePath which is only relevant for MatchExpressions The proposed idea is to split that out so we would have MatchExpression::serialize(bool includePath, SerializationOptions = {})
|
| Comments |
| Comment by Githook User [ 06/Oct/23 ] |
|
Author: {'name': 'Reilly McBride', 'email': 'reilly.mcbride@mongodb.com', 'username': ''}Message: |
| Comment by Charlie Swanson [ 03/Apr/23 ] |
|
I'm adding the back to the epic for consideration. I think this is indeed an optional refactor, but I would advocate to spend the time on it while we're here and paying attention. It will make the code much more self-documenting and modularized, which will aid many future readers. |