[SERVER-74180] Verify whether StreamableReplicaSetMonitor::getHostsOrRefresh should wait for the refresh Created: 17/Feb/23  Updated: 29/Jun/23  Resolved: 29/Jun/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Randolph Tan Assignee: Sanika Phanse (Inactive)
Resolution: Won't Fix Votes: 0
Labels: sharding-nyc-subteam2
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Assigned Teams:
Sharding NYC
Sprint: Sharding NYC 2023-05-29, Sharding NYC 2023-06-12, Sharding NYC 2023-06-26, Sharding NYC 2023-07-10
Participants:
Linked BF Score: 26
Story Points: 2

 Description   

It looks like StreamableReplicaSetMonitor::getHostsOrRefresh doesn't actually wait for refresh to update the latest topology before trying to get hosts after requesting an async refresh

It's not clear whether this was intentional or maybe I misread the code.

The purpose of this ticket is to investigate if we want to keep this async or not by looking at the usages of StreamableReplicaSetMonitor::getHostsOrRefresh. 



 Comments   
Comment by Sanika Phanse (Inactive) [ 29/Jun/23 ]

Verified that async behavior is intentional; however, we will add a retry policy at a higher level (potentially the targeter) to block the user thread until the topology change is detectable.

Generated at Thu Feb 08 06:26:44 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.