[SERVER-74289] Add statistics for secure allocator to server status Created: 22/Feb/23  Updated: 08/Jan/24  Resolved: 08/Jan/24

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.3.0-rc0

Type: Task Priority: Major - P3
Reporter: Mark Benvenuto Assignee: Niaz Pavel
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Related
related to SERVER-74038 [Windows] Possible negative performan... Closed
Assigned Teams:
Server Security
Backwards Compatibility: Fully Compatible
Sprint: Security 2023-11-27, Security 2023-12-11, Security 2023-12-25, Security 2024-01-08, Security 2024-01-22
Participants:
Linked BF Score: 148

 Description   

The secure allocator pins pages into memory in the hope that they are not paged to disk. There are not statistics that break down how many pages and how many bytes are being consumed in this system.

Extend the "mem" section of server status with two new counters:

  1. Count of allocated "secure reserved memory" in bytes. Keep track of the memory allocated in systemAllocate/systemDeallocate
  2. Count of allocated "secure bytes" in bytes. Keep track of bytes allocated/deallocated in GlobalSecureAllocator::allocate

 



 Comments   
Comment by Niaz Pavel [ 08/Jan/24 ]

https://github.com/10gen/mongo/pull/17401

Comment by Githook User [ 05/Jan/24 ]

Author:

{'name': 'Niaz Pavel', 'email': 'niaz.pavel@mongodb.com', 'username': 'niazpavelatmongo'}

Message: SERVER-74289 Add statistics for secure allocator to server status

GitOrigin-RevId: 57cc975fdf62c6db3b127b9faa44f822d15ddb86
Branch: master
https://github.com/mongodb/mongo/commit/0256daa28c20645c36fb3581b5bd5ff2521b143c

Comment by Niaz Pavel [ 03/Jan/24 ]

This is accidently closed by me. https://github.com/10gen/mongo/pull/17401

Comment by Niaz Pavel [ 02/Jan/24 ]

This probably got reopened by me when BF-31144 was found. As it is fixed now, we can close this.

Comment by Niaz Pavel [ 12/Dec/23 ]

https://github.com/10gen/mongo/pull/17401

Comment by Githook User [ 12/Dec/23 ]

Author:

{'name': 'aleksei.vasilev', 'email': 'aleksei.vasilev@mongodb.com', 'username': 'AlexVasilOne'}

Message: Revert "SERVER-74289 added static cast to convert size_t to int32_t"

This reverts commit d3d1f76059ab374bdaa8f7db3d035a7f03360848.

GitOrigin-RevId: a497543630ecda29023f0fd3459756183de15f33
Branch: master
https://github.com/mongodb/mongo/commit/f2dfddf2a4e819cc1bd003e173bfa35f8373207a

Comment by Githook User [ 12/Dec/23 ]

Author:

{'name': 'Niaz Pavel', 'email': 'niaz.pavel@mongodb.com', 'username': 'niazpavelatmongo'}

Message: SERVER-74289 added static cast to convert size_t to int32_t

GitOrigin-RevId: d3d1f76059ab374bdaa8f7db3d035a7f03360848
Branch: master
https://github.com/mongodb/mongo/commit/4e894a7ad292859bd8490e6fcaffa551fcd6073f

Comment by Niaz Pavel [ 07/Dec/23 ]

Mark is reviewing my code.

Generated at Thu Feb 08 06:27:02 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.