[SERVER-74420] Set up the import of tcmalloc Created: 27/Feb/23 Updated: 29/Oct/23 Resolved: 25/May/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Billy Donahue | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Service Arch 2023-03-06, Service Arch 2023-03-20, Service Arch 2023-04-03, Service Arch 2023-04-17, Service Arch 2023-05-01, Service Arch 2023-06-12 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
write a canonical third_party import script for vendoring mongodb-forks/tcmalloc |
| Comments |
| Comment by Blake Oler [ 25/May/23 ] |
|
For purposes of testing for this project, this ticket is complete. |
| Comment by Billy Donahue [ 23/Mar/23 ] |
|
Blaze is executable as Python. Scons is executable as Python. I have an idea that we can have the Scons Python interpreter compile and execute the tcmalloc bazel files, in an environment that implements the Bazel API in terms of the Scons API. Early experiments seem promising. |
| Comment by Billy Donahue [ 22/Mar/23 ] |
|
Nevermind that design. Unlike Abseil, TCMalloc isn't shipped with CMake rules. Just Bazel BUILD files. So the script we used to get Abseil-cpp into SCsons isn't going to work, and I'll have to try something else. The unofficial Google bazel-to-cmake tool is 4 years old and no longer understands modern Bazel files. Will have to do something else. |
| Comment by Billy Donahue [ 21/Mar/23 ] |
|
The design here will be a variant of the script used to import abseil-cpp, generating SConscript from the ninja deps graph. |