[SERVER-74443] Make auto-updating assertions work on single-line assertions Created: 28/Feb/23  Updated: 13/Mar/23  Resolved: 13/Mar/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Davis Haupt (Inactive) Assignee: Davis Haupt (Inactive)
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Participants:

 Description   

Right now, auto-updating assertions need to be spread across multiple lines to work properly. New assertions are generally written in this format to avoid being collapsed by clang-format to a single line:

ASSERT_STR_EQ_AUTO( // NOLINT
    "",
    actualOutput);

This is cumbersome to write and leads to very strange behavior if not done properly. To be more user-friendly, auto-updating assertions should be able to be written like so:

ASSERT_STR_EQ_AUTO("", actualOutput);

and the expected output should be filled in as expected.



 Comments   
Comment by Davis Haupt (Inactive) [ 13/Mar/23 ]

After synchronous discussion, we won't do this now, and will close unless this becomes a larger pain point in the future.

Generated at Thu Feb 08 06:27:27 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.