[SERVER-74482] Remove unnecessary calls to ClusterClientCursor::kill Created: 01/Mar/23  Updated: 29/Oct/23  Resolved: 28/Apr/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Will Buerger Assignee: Gil Alon
Resolution: Fixed Votes: 0
Labels: quick-tech-debt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Query Integration
Backwards Compatibility: Fully Compatible
Participants:

 Description   

In some cases, ClusterClientCursor::kill is called more than once on a given cursor; for now, extra calls are treated as a no-op, but we should investigate where kill is being called unnecessarily and remove unnecessary ones.



 Comments   
Comment by Githook User [ 28/Apr/23 ]

Author:

{'name': 'Gil Alon', 'email': 'gil.alon@mongodb.com', 'username': 'galon1'}

Message: SERVER-74482 Add conditional to avoid unnecessary calls to ClusterClientCursor::kill
Branch: master
https://github.com/mongodb/mongo/commit/ab15cb29a43ea6a3b76c6fa9764dc4839558f85c

Comment by Will Buerger [ 20/Mar/23 ]

mihai.andrei@mongodb.com, that sounds appropriate, and Ted agrees! Moving to QI backlog

Comment by Will Buerger [ 08/Mar/23 ]

kyle.suarez@mongodb.com In SERVER-73727 we realized that ClusterClientCursor::kill was being called unnecessarily multiple times for some cursors. We changed it to explicitly act as a no-op after the first call and filed this as a cleanup effort. No correctness issue or expected performance improvements; this is more of a tech debt ticket, so no need to schedule.

Comment by Kyle Suarez [ 07/Mar/23 ]

will.buerger@mongodb.com, what is the context from which this ticket originated? Is the desire to remove the extra calls to kill motivated by, say, performance? If there is no correctness issue we are not particularly inclined to schedule this.

Generated at Thu Feb 08 06:27:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.