[SERVER-74563] Streamline logical branches in opObserverImpl::onInserts Created: 02/Mar/23 Updated: 29/Oct/23 Resolved: 27/Apr/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Benety Goh | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Assigned Teams: |
Storage Execution
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Sprint: | Execution Team 2023-04-17, Execution Team 2023-05-01 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
The objective of this ticket is to be able to create a MutableOplogEntry in OpObserverImpl::onInserts and pass that to logMutableOplogEntry to route to its eventual destination (batched writes/multi-doc txn/write-through to oplog). |
| Comments |
| Comment by Benety Goh [ 27/Apr/23 ] |
|
We consolidated the oplog entry formatting code that used to be split between OpObserverImpl and oplog.cpp into one location within OpObserverImpl. The insert formatting code works on a range of insert operations, which is a little different from the rest of the oplog entry formatting callbacks in OpObserver which work on single operations. As such, we decided to leave the insert formatting logic separate from the rest of the CRUD and DDL operations. |
| Comment by Githook User [ 26/Apr/23 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: The implementation has been moved to OpObserverImpl. |
| Comment by Githook User [ 26/Apr/23 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Githook User [ 26/Apr/23 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: This consolidates the insert oplog entry logic in op_observer_impl.cpp. |
| Comment by Githook User [ 26/Apr/23 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Githook User [ 26/Apr/23 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Githook User [ 26/Apr/23 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: Last reference to std::deque was removed in commit 6543f0dea026b6ff9ad6f701a8f6ca62f0679613. |
| Comment by Githook User [ 26/Apr/23 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Githook User [ 26/Apr/23 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |