[SERVER-74589] move logic for marking orphan documents out of logOplogInserts Created: 03/Mar/23  Updated: 29/Oct/23  Resolved: 29/Mar/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.0.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Related
is related to SERVER-62581 Handle direct inserts to shards intro... Closed
is related to SERVER-65858 Mark the applyOps entries when the op... Closed
is related to SERVER-74563 Streamline logical branches in opObse... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2023-03-20, Execution Team 2023-04-03
Participants:
Linked BF Score: 135

 Description   

When we write oplog entries for insert operations, we have to identify any orphan documents in the operations and override the default fromMigrate setting accordingly.

The corresponding logic for overriding the fromMigrate setting happens in the query stages for deletes and updates above the OpObserver layer, so it would be consistent to evaluate this setting for inserts outside the OpObserver framework.



 Comments   
Comment by Githook User [ 29/Mar/23 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-74589 mark orphan documents for inserts in insertDocumentsImpl() before calling OpObserver
Branch: master
https://github.com/mongodb/mongo/commit/c9a5f04d3c9a3e570afbe9a37b7f890319a618bd

Comment by Githook User [ 28/Mar/23 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-74589 move write_stage_common::PreWriteFilter into its own library
Branch: master
https://github.com/mongodb/mongo/commit/16ea4e86288e750714d5a5d48e05eab9fdcfcdd8

Comment by Githook User [ 28/Mar/23 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-74589 OpObserver::onInserts() accepts fromMigrate bool array
Branch: master
https://github.com/mongodb/mongo/commit/8754d07ae5dad44417fd232595605aa5fabbc99a

Comment by Githook User [ 28/Mar/23 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-74589 OplogWriter::logInsertOps() accepts fromMigrate bool array
Branch: master
https://github.com/mongodb/mongo/commit/c5519fd438f2880e7a80fe60cdb3ab3e5dc0712a

Comment by Githook User [ 28/Mar/23 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-74589 repl::logInsertOps() accepts fromMigrate bool array
Branch: master
https://github.com/mongodb/mongo/commit/5fe0905f5b88bfc7eb267b4743787ae96090b6eb

Comment by Githook User [ 28/Mar/23 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-74589 OpObserverImpl::onInserts() should create well-formed MutableOplogEntry that can be serialized for logging
Branch: master
https://github.com/mongodb/mongo/commit/25b081776a5bf6b5207284fe049cb88620f91efb

Generated at Thu Feb 08 06:27:53 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.