[SERVER-74662] Query work to revisit if threads currently marked as "unkillable"(meaning non-interruptible) should instead be interruptable Created: 07/Mar/23  Updated: 29/Oct/23  Resolved: 21/Aug/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Jiawei Yang Assignee: Rushan Chen
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-70127 Default system operations to be killa... Closed
Assigned Teams:
Query Execution
Backwards Compatibility: Fully Compatible
Sprint: QE 2023-05-15, QE 2023-05-29, QE 2023-06-12, QE 2023-06-26, QE 2023-07-10, QE 2023-07-24, QE 2023-08-07, QE 2023-08-21, QE 2023-09-04
Participants:

 Description   

InĀ SERVER-70127, we changed the default behavior of a thread to be killable by default. We now marked all threads that were not marked as killable before to be unkillable, but it could be there are threads not necessary to be unkillable.

Here killable means interruptable. The thread itself is not canceled if the interrupt is handled.

This ticket is created for teams owning relative code directories to revisit whether these threads should be marked as unkillable.

You can search the ticket number(SERVER-74662) to lookup TODO threads.



 Comments   
Comment by Githook User [ 18/Aug/23 ]

Author:

{'name': 'Rushan Chen', 'email': 'rushan.chen@mongodb.com', 'username': 'ruchen'}

Message: SERVER-74662 Confirm changes in query code if threads are killable by default
Branch: master
https://github.com/mongodb/mongo/commit/fcf620d0bdb77c2c59f5d7f80d99b1ba5768be46

Comment by Rushan Chen [ 25/May/23 ]

I marked the spreadsheet based on the what little I can find in the header files. There is no one on my team who has deeper knowledge than trying to gleam clues from the code. Probably best to have another person taking a look.

Separately, is marking the spreadsheet the action to be performed by this audit? It's not clear what "Non Action" and "server ticket" means in the column heading so I just marked whether threads should be non killable or not.

Comment by Ana Meza [ 14/Mar/23 ]

Passing this to query-director-triage to assign priority

Comment by Kyle Suarez [ 07/Mar/23 ]

jiawei.yang@mongodb.com, as your other ticket is still in code review, I am leaving this in the triage queue. (At first glance, though, it seems like the ClientCursorMonitor and some strange thread in DocumentSourceOut are the query-related ones so far. The ClientCursorMonitor should not be killed, though.)

Generated at Thu Feb 08 06:28:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.