[SERVER-74832] Resmoke description field does not work for suites that get split up Created: 14/Mar/23  Updated: 29/Oct/23  Resolved: 07/May/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0, 7.0.0-rc1

Type: Bug Priority: Minor - P4
Reporter: Trevor Guidry Assignee: Namaz Gurbanov
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Assigned Teams:
Decision Automation Group
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v7.0, v6.3
Sprint: DAG 2023-05-15
Participants:

 Description   

We have some suites like the `sharding` suites that get split up into `sharding[0-4]`

 

The description field seems to not be transferred over to these subsuites. The local resmoke invocation also seems to be wrong.

 

An example broken local invocation can be seen here:

 

```

[2023/03/14 07:11:17.833] [resmoke] 07:11:17.833Z verbatim resmoke.py invocation: buildscripts/resmoke.py run --originSuite=sharding_max_mirroring_opportunistic_secondary_targeting_ese_gcm --jobs=8 --shuffle --continueOnFailure --storageEngineCacheSizeGB=1 --excludeWithAnyTags=requires_ocsp_stapling --excludeWithAnyTags=incompatible_with_shard_merge --additionalFeatureFlagsFile all_feature_flags.txt --suites=generated_resmoke_config/sharding_max_mirroring_opportunistic_secondary_targeting_ese_gcm_0-linux-enterprise.yml --log=buildlogger --staggerJobs=on --installDir=dist-test/bin --buildId=mongodb_mongo_master_rhel80_debug_aubsan_lite_all_feature_flags_suggested_patch_2a63799389d72a64cdfd9f19eb589a24ca56524a_640ffd561e2d17d19b800359_23_03_14_04_59_01 --distroId=rhel80-large --executionNumber=1 --projectName=mongodb-mongo-master --gitRevision=2a63799389d72a64cdfd9f19eb589a24ca56524a --revisionOrderId=trevor.guidry_264 --taskId=mongodb_mongo_master_rhel80_debug_aubsan_lite_all_feature_flags_suggested_sharding_max_mirroring_opportunistic_secondary_targeting_ese_gcm_0_linux_enterprise_patch_2a63799389d72a64cdfd9f19eb589a24ca56524a_640ffd561e2d17d19b800359_23_03_14_04_59_01 --taskName=sharding_max_mirroring_opportunistic_secondary_targeting_ese_gcm_0-linux-enterprise --variantName=rhel80-debug-aubsan-lite-all-feature-flags-suggested --versionId=640ffd561e2d17d19b800359 --reportFile=report.json --perfReportFile=perf.json --cedarReportFile=cedar_report.json

[2023/03/14 07:11:17.841][resmoke] 07:11:17.844Z resmoke.py invocation for local usage: LANG=C UBSAN_OPTIONS="print_stacktrace=1:external_symbolizer_path=/opt/mongodbtoolchain/v4/bin/llvm-symbolizer" LSAN_OPTIONS="suppressions=etc/lsan.suppressions:report_objects=1"

```

 

https://mongodb.slack.com/archives/C0V79S1PY/p1678803938963629

 



 Comments   
Comment by Githook User [ 08/May/23 ]

Author:

{'name': 'Namaz Gurbanov', 'email': 'namaz.gurbanov@mongodb.com', 'username': 'namazgurbanovmdb'}

Message: SERVER-74832 Resmoke description field does not work for suites that get split up
Branch: v7.0
https://github.com/mongodb/mongo/commit/057b244650e85f1fd81fb27769f5fb2353429779

Comment by Githook User [ 06/May/23 ]

Author:

{'name': 'Namaz Gurbanov', 'email': 'namaz.gurbanov@mongodb.com', 'username': 'namazgurbanovmdb'}

Message: SERVER-74832 Resmoke description field does not work for suites that get split up
Branch: master
https://github.com/mongodb/mongo/commit/948bf37c910d9911160e3b275d3c51b146a9c923

Comment by Namaz Gurbanov [ 04/May/23 ]

Introduced them as optional fields. The PR is out.

Comment by Trevor Guidry [ 03/May/23 ]

It is an optional field, same with the `matrix_suite` field. They should only be added when the base suite contains them. Is that a problem for the mongo-task-generator?

Comment by Namaz Gurbanov [ 03/May/23 ]

Adding description causes a failure because some of the suites do not have a description. Should they be backfilled before implementing this change?

Comment by Trevor Guidry [ 02/May/23 ]

One thing I forgot to mention in the initial ticket is that there is a `matrix_suite` field also that I think needs to be included in the generated suites also.

Comment by Alex Neben [ 17/Apr/23 ]

It should be an easy fix and I think it does belong to dag.

Comment by Trevor Guidry [ 17/Apr/23 ]

iryna.zhuravlova@mongodb.com DAG owns the mongo-task-generator so I thought they were the correct person for this but it seems like we will be working on the mongo-task-generator soon so we can take this back if needed.

Comment by Iryna Zhuravlova [ 17/Apr/23 ]

trevor.guidry@mongodb.com Should this ticket be assigned to DAG? 

Comment by Trevor Guidry [ 27/Mar/23 ]

I think the fix for this lies in `mongo-task-generator`. The generated suites from mongo-task-generator do not include the description field.

 

I think a description string field just needs to be added here. https://github.com/mongodb/mongo-task-generator/blob/master/src/resmoke/resmoke_suite.rs#L83

 

This is testable by using 

python3 ./buildscripts/resmoke.py suiteconfig --suite replica_sets_max_mirroring_large_txns_format

 

it will output 

 

{{description: This suite is a combination of replica_sets_max_mirroring and replica_sets_large_txns_format.
  You can run any of these tests individually to debug any issues that might arrise.
executor:
  archive:
    tests: true
  config:
    shell_options:
      global_vars:
        TestData:
          setParameters:
            maxNumberOfTransactionOperationsInSingleOplogEntry: 1
            mirrorReads: '{samplingRate: 1.0}'
      nodb: ''
matrix_suite: true
selector:
  exclude_files:
  - jstests/replsets/tenant_migration_recipient_shard_merge_copies_change_collections.js
  exclude_with_any_tags:
  - requires_capped
  roots:
  - jstests/replsets/*.js
test_kind: js_test}}

 

 

The generated suite looks like this:

{{---
test_kind: js_test
selector:
  exclude_with_any_tags:
    - requires_capped
  roots:
    - ......
executor:
  archive:
    tests: true
  config:
    shell_options:
      global_vars:
        TestData:
          setParameters:
            maxNumberOfTransactionOperationsInSingleOplogEntry: 1
            mirrorReads: "{samplingRate: 1.0}"
      nodb: ""

}}

 

 

 

Generated at Thu Feb 08 06:28:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.