[SERVER-74894] Header includes in files generated from accumulator spec in IDL Created: 15/Mar/23  Updated: 03/Feb/24

Status: Backlog
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Irina Yatsenko (Inactive) Assignee: Backlog - Query Integration
Resolution: Unresolved Votes: 0
Labels: qi-tech-debt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Query Integration
Operating System: ALL
Sprint: QE 2023-03-20, QE 2023-04-03
Participants:

 Description   

For the $percentile accumulator we are using an IDL spec (accumulator_percentile.idl) and we need to include 'accumulator_percentile.h' into the generated cpp file to perform some additional custom validation of the arguments. However, the generated code adds the include into 'accumulator_percentile_gen.h' rather than 'accumulator_percentile_gen.cpp' making it impossible to use types – e.g. PercentileAlgorithmTypeEnum enum – defined via the IDL, in accumulator_percentile.h.

The reason to include into the generated header is that the purpose of the includes is likely to be the custom types for the "types" fields. So we cannot just move the include into the generated cpp file but we can add another field, something like "cpp_impl_includes" for headers that are meant to be included only into the generated cpp file.


Generated at Thu Feb 08 06:28:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.