[SERVER-74907] Use tassert in NamespaceStringUtil functions Created: 15/Mar/23  Updated: 22/Jan/24  Resolved: 22/Jan/24

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Janna Golden Assignee: Backlog - Service Architecture
Resolution: Won't Fix Votes: 0
Labels: ntdi_must_have
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-76040 Make mirrored requests to include ten... Closed
depends on SERVER-77723 Turn parseNamespaceFromRequest calls ... Closed
depends on SERVER-78534 Only allow specific global collection... Closed
Assigned Teams:
Service Arch
Sprint: Server Serverless 2023-08-21, Server Serverless 2023-10-02
Participants:
Story Points: 4

 Description   

Change the masserts to tasserts.



 Comments   
Comment by Didier Nadeau [ 22/Jan/24 ]

Closing as there's no clear motivation to use tassert.

Comment by Sophia Tan [ 03/Jul/23 ]

[j0:prim] {"t":{"$date":"2023-07-03T01:27:01.454+00:00"},"s":"I",  "c":"CONTROL",  "id":31445,   "ctx":"conn44","msg":"Frame","attr":{"frame":{"a":"7F5     41FDA44C3","b":"7F541FB6D000","o":"2374C3","s":"_ZN5mongo13tassertFailedERKNS_6StatusENS_14SourceLocationE","C":"mongo::tassertFailed(mongo::Status con     st&, mongo::SourceLocation)","s+":"B3"}}}
3753 [j0:prim] {"t":{"$date":"2023-07-03T01:27:01.454+00:00"},"s":"I",  "c":"CONTROL",  "id":31445,   "ctx":"conn44","msg":"Frame","attr":{"frame":{"a":"7F5     414DD1F84","b":"7F5414DC5000","o":"CF84","s":"_ZZN5mongo19NamespaceStringUtil21deserializeForStorageEN5boost8optionalINS_8TenantIdEEENS_10StringDataERK     NS_20SerializationContextEENK3$_1clEv","C":"mongo::NamespaceStringUtil::deserializeForStorage(boost::optional<mongo::TenantId>, mongo::StringData, mong     o::SerializationContext const&)::$_1::operator()() const","s+":"C4"}}}
3754 [j0:prim] {"t":{"$date":"2023-07-03T01:27:01.454+00:00"},"s":"I",  "c":"CONTROL",  "id":31445,   "ctx":"conn44","msg":"Frame","attr":{"frame":{"a":"7F5     414DD1DF2","b":"7F5414DC5000","o":"CDF2","s":"_ZN5mongo19NamespaceStringUtil21deserializeForStorageEN5boost8optionalINS_8TenantIdEEENS_10StringDataERKN     S_20SerializationContextE","C":"mongo::NamespaceStringUtil::deserializeForStorage(boost::optional<mongo::TenantId>, mongo::StringData, mongo::Serializa     tionContext const&)","s+":"472"}}}
3755 [j0:prim] {"t":{"$date":"2023-07-03T01:27:01.454+00:00"},"s":"I",  "c":"CONTROL",  "id":31445,   "ctx":"conn44","msg":"Frame","attr":{"frame":{"a":"7F5     414DD0F5B","b":"7F5414DC5000","o":"BF5B","s":"_ZN5mongo19NamespaceStringUtil11deserializeEN5boost8optionalINS_8TenantIdEEENS_10StringDataERKNS_20Serial     izationContextE","C":"mongo::NamespaceStringUtil::deserialize(boost::optional<mongo::TenantId>, mongo::StringData, mongo::SerializationContext const&)"     ,"s+":"CB"}}}
3756 [j0:prim] {"t":{"$date":"2023-07-03T01:27:01.454+00:00"},"s":"I",  "c":"CONTROL",  "id":31445,   "ctx":"conn44","msg":"Frame","attr":{"frame":{"a":"7F5     414DD3194","b":"7F5414DC5000","o":"E194","s":"_ZN5mongo19NamespaceStringUtil25parseNamespaceFromRequestERKNS_12DatabaseNameENS_10StringDataE","C":"mong     o::NamespaceStringUtil::parseNamespaceFromRequest(mongo::DatabaseName const&, mongo::StringData)","s+":"284"}}}
3757 [j0:prim] {"t":{"$date":"2023-07-03T01:27:01.454+00:00"},"s":"I",  "c":"CONTROL",  "id":31445,   "ctx":"conn44","msg":"Frame","attr":{"frame":{"a":"7F5     4152DAD37","b":"7F54152A6000","o":"34D37","s":"_ZN5mongo25KillCursorsCommandRequest14parseProtectedERKNS_16IDLParserContextERKNS_12OpMsgRequestE","C":"     mongo::KillCursorsCommandRequest::parseProtected(mongo::IDLParserContext const&, mongo::OpMsgRequest const&)","s+":"B57"}}}
3758 [j0:prim] {"t":{"$date":"2023-07-03T01:27:01.454+00:00"},"s":"I",  "c":"CONTROL",  "id":31445,   "ctx":"conn44","msg":"Frame","attr":{"frame":{"a":"7F5     4152DA0FE","b":"7F54152A6000","o":"340FE","s":"_ZN5mongo25KillCursorsCommandRequest5parseERKNS_16IDLParserContextERKNS_12OpMsgRequestE","C":"mongo::Kil     lCursorsCommandRequest::parse(mongo::IDLParserContext const&, mongo::OpMsgRequest const&)","s+":"8E"}}}
3759 [j0:prim] {"t":{"$date":"2023-07-03T01:27:01.454+00:00"},"s":"I",  "c":"CONTROL",  "id":31445,   "ctx":"conn44","msg":"Frame","attr":{"frame":{"a":"7F5     40F5E36E2","b":"7F540F4BC000","o":"1276E2","s":"_ZN5mongo12TypedCommandINS_18KillCursorsCmdBaseINS_14KillCursorsCmdEEEE22InvocationBaseInternal13_parse     RequestEPNS_16OperationContextEPKNS_7CommandERKNS_12OpMsgRequestE","C":"mongo::TypedCommand<mongo::KillCursorsCmdBase<mongo::KillCursorsCmd> >::Invocat     ionBaseInternal::_parseRequest(mongo::OperationContext*, mongo::Command const*, mongo::OpMsgRequest const&)","s+":"102"}}}
3760 [j0:prim] {"t":{"$date":"2023-07-03T01:27:01.454+00:00"},"s":"I",  "c":"CONTROL",  "id":31445,   "ctx":"conn44","msg":"Frame","attr":{"frame":{"a":"7F5     40F5E2814","b":"7F540F4BC000","o":"126814","s":"_ZSt11make_uniqueIN5mongo18KillCursorsCmdBaseINS0_14KillCursorsCmdEE10InvocationEJRPNS0_16OperationCont     extEPNS0_12TypedCommandIS3_EERKNS0_12OpMsgRequestEEENSt9_MakeUniqIT_E15__single_objectEDpOT0_","C":"std::_MakeUniq<mongo::KillCursorsCmdBase<mongo::Kil     lCursorsCmd>::Invocation>::__single_object std::make_unique<mongo::KillCursorsCmdBase<mongo::KillCursorsCmd>::Invocation, mongo::OperationContext*&, mo     ngo::TypedCommand<mongo::KillCursorsCmdBase<mongo::KillCursorsCmd> >*, mongo::OpMsgRequest const&>(mongo::OperationContext*&, mongo::TypedCommand<mongo     ::KillCursorsCmdBase<mongo::KillCursorsCmd> >*&&, mongo::OpMsgRequest const&)","s+":"54"}}}

Generated at Thu Feb 08 06:28:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.