[SERVER-7504] Core Server Headers should not include basic.h Created: 29/Oct/12 Updated: 30/Aug/23 Resolved: 29/Aug/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Client, Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Andy Schwerin | Assignee: | [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive) |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Assigned Teams: |
Server Development Platform
|
||||||||||||
| Participants: | |||||||||||||
| Description |
|
Per style guide, only cpp file should include these, to avoid leaking unwanted using declarations, includes and macros to client code. |
| Comments |
| Comment by Andy Schwerin [ 30/Aug/23 ] |
|
Response posted in |
| Comment by Alex Neben [ 29/Aug/23 ] |
|
This is in the opposite of |
| Comment by Eric Milkie [ 23/Nov/16 ] |
|
We still have quite a few headers that include basic.h, but they aren't necessarily "core". |
| Comment by Tad Marshall [ 29/Oct/12 ] |
|
We should talk about this ... there is a certain beauty in keeping headers pch.h is junk, I'm happy to see it kicked out of headers. <windows.h> is This also requires changes to the rules for include files. Some cpp files |