Addess recent performance regressions in mixed workloads (SERVER-74848)

[SERVER-75117] Avoid NamespaceString copies when possible Created: 21/Mar/23  Updated: 29/Oct/23  Resolved: 04/Apr/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.0.0-rc0

Type: Sub-task Priority: Major - P3
Reporter: Colin Stolley Assignee: Colin Stolley
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-75529 Revisit memory layout for TenantId, D... Closed
Backwards Compatibility: Fully Compatible
Participants:

 Description   

There's a bunch of functions which take copies of NamespaceString objects for no reason, and in the hot path these add up. Use const references instead when it's safe to do so.

 

See:

src/mongo/db/curop.h

src/mongo/db/commands.cpp

src/mongo/db/op_observer/op_observer_impl.h



 Comments   
Comment by Githook User [ 03/Apr/23 ]

Author:

{'name': 'Colin Stolley', 'email': 'ccstolley@github.com', 'username': 'ccstolley'}

Message: SERVER-75117: Avoid passing NamespaceString by value when possible.
Branch: master
https://github.com/mongodb/mongo/commit/70c7c17bc5ef3cab7ca0e9836757209e5ed26d68

Generated at Thu Feb 08 06:29:21 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.