[SERVER-75129] Allow SBE compatibility check to distinguish featureFlagSbeFull Created: 22/Mar/23 Updated: 29/Oct/23 Resolved: 27/Mar/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.0.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Rui Liu | Assignee: | Rui Liu |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | QE 2023-04-03 |
| Participants: |
| Description |
|
Currently the "sbeCompatible" and "sbeGroupCompatible" flags are used to check whether the expressions and accumulators are supported in SBE. The values are of boolean type, but we really have three levels of support in SBE, given that some SBE-compatible features are not enabled if "featureFlagSbeFull" is not enabled. So we should change that value to an enum. Alternatively, we could set the "sbeCompatible" flag to false if the "featureFlagSbeFull" is false. But that's slightly hacky, and we would need to scatter the check of "featureFlagSbeFull" in multiple places. Capture the real level of compatibility seems appropriate. |
| Comments |
| Comment by Githook User [ 24/Mar/23 ] |
|
Author: {'name': 'Rui Liu', 'email': 'lriuui0x0@gmail.com', 'username': 'lriuui0x0'}Message: |