[SERVER-75156] Separate query shape from telemetry key Created: 22/Mar/23  Updated: 02/Feb/24  Resolved: 27/Apr/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Davis Haupt (Inactive) Assignee: Maddie Zechar
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-76517 Separate query shape from telemetry k... Closed
is depended on by SERVER-76143 Add missing fields to telemetry key Closed
Backwards Compatibility: Fully Compatible
Sprint: QO 2023-04-03, QO 2023-04-17, QO 2023-05-01
Participants:

 Description   

HACK: we are just going to restructure the BsonObj that we return from makeTelemetryKey to nest all fields designated as part of the query shape by the design doc, under a new field, "queryShape"



 Comments   
Comment by Githook User [ 02/Feb/24 ]

Author:

{'name': 'Erin Zhu', 'email': 'erin.zhu@mongodb.com', 'username': 'erinzhu001'}

Message: SERVER-86118 Query Stats Backport to 7.0 Batch #2

Includes community changes from
SERVER-73907 Ensure telemetry command succeeds after raising FCV
SERVER-75609 Graceful telemetry failures and error tracking
SERVER-75156 separate queryShape from telemetryKey for find requests
SERVER-76610 account for queryShape nesting in telemetry store key
SERVER-76367: Abstract request-specific shapifying logic into RequestShapifiers
SERVER-76424 Replace 'redact' with 'hmac' in $telemetry syntax
SERVER-76781: Decouple opdebug metric collection from telemetry
SERVER-76208 support query shape serialization in IDL for types with custom serializers
with querystats related serialization/redaction changes from
SERVER-72687 Support for $out to Time-series collections

and enterprise changes from
SERVER-76610 account for queryShape nesting in telemetry store key
SERVER-76424 Replace 'redact' with 'hmac' in $telemetry syntax

GitOrigin-RevId: f424d1b1848f85581a870c061b1231219748c00c
Branch: v7.0
https://github.com/mongodb/mongo/commit/5dc8bc61dfdc550f8d643a4db5d3564a21e24245

Comment by Githook User [ 26/Apr/23 ]

Author:

{'name': 'Maddie Zechar', 'email': 'mez2113@columbia.edu', 'username': ''}

Message: SERVER-75156 separate queryShape from telemetryKey for find requests
Branch: master
https://github.com/mongodb/mongo/commit/b9de639b5fca5794c83314b1a302008569d51bd3

Comment by Davis Haupt (Inactive) [ 06/Apr/23 ]

Another thought I had is that this ticket should probably also codify the telemetry key as an IDL type. It will make it much easier to construct, serialize, and hash, and also give us a bit of type safety to make sure we're constructing it properly everywhere.

Comment by Maddie Zechar [ 31/Mar/23 ]

We are shooting for 7.0 code freeze, so stopping progress on this refactor in order to work on high priority tickets to get us across the finish line

Generated at Thu Feb 08 06:29:28 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.