[SERVER-75387] Confirm FeatureFlag::isEnabledAndIgnoreFCVUnsafe() usage for storage execution Created: 28/Mar/23  Updated: 27/Oct/23  Resolved: 05/Apr/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Jiawei Yang Assignee: Jiawei Yang
Resolution: Gone away Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-66587 Rename isEnabledAndIgnoreFCV() to be ... Closed
Participants:

 Description   

We formalized the usage of FeatureFlag::isEnabledAndIgnoreFCV() in https://jira.mongodb.org/browse/SERVER-66587. Now every usage of FeatureFlag::isEnabledAndIgnoreFCV() is changed to FeatureFlag::isEnabledAndIgnoreFCVUnsafe() and ask the engineer to add a comment describing why you have to ignore FCV here.

Overall, we expect places that are using FeatureFlag::isEnabledAndIgnoreFCVUnsafe() now to be:

  • isEnabledAndIgnoreFCVAtStartup() if this feature flag check is before FCV initialization.
  • Stay isEnabledAndIgnoreFCVUnsafe() if you have a reason, and update your reason in the comment line starting with (Ignore FCV check):
  • Change to isEnabled(FCV).

Here are the feature flags that are using isEnabledAndIgnoreFCVUnsafe:

  • gPointInTimeCatalogLookups
  • gFeatureFlagDeprioritizeLowPriorityOperations
  • gIndexBuildGracefulErrorHandling
  • gFeatureFlagExecutionControl

You can also search for TODO(SERVER-75387) for all places need to revisit


Generated at Thu Feb 08 06:30:03 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.